lisyarus/psemek
1
0
Fork 1
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix math overflow crash in computing profiling statistics

Browse source
This commit is contained in:
Nikita Lisitsa 2024-07-29 14:16:51 +03:00
parent 3856fdd827
commit ddaf2407a9
1 changed files with 13 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
libs/util/include/psemek/util/statistics.hpp
View file

@ -94,16 +94,24 @@ namespace psemek::util
// https://en.wikipedia.org/wiki/Maximum_entropy_probability_distribution#Other_examples // https://en.wikipedia.org/wiki/Maximum_entropy_probability_distribution#Other_examples
// https://en.wikipedia.org/wiki/Truncated_normal_distribution // https://en.wikipedia.org/wiki/Truncated_normal_distribution
float const mu = mean(); T const mu = mean();
float const sigma = stddev(); T const sigma = stddev();
if (sigma == T{0}) if (sigma == T{0})
return mu; return mu;
float const alpha = (min - mu) / sigma; T const alpha = (min - mu) / sigma;
float const beta = (max - mu) / sigma; T const beta = (max - mu) / sigma;
return mu + sigma * detail::normal_cdf_inv(std::lerp(detail::normal_cdf(alpha), detail::normal_cdf(beta), p)); T const t = std::lerp(detail::normal_cdf(alpha), detail::normal_cdf(beta), p);
if (t <= T{0})
return min;
if (t >= T{1})
return max;
return mu + sigma * detail::normal_cdf_inv(t);
} }
friend base_statistics merge(base_statistics const & s1, base_statistics const & s2) friend base_statistics merge(base_statistics const & s1, base_statistics const & s2)