lisyarus/psemek
1
0
Fork 1
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix geom::acos_over_sqrt_1_minus_x2 to allow arguments slightly larger than 1 to prevent NaNs

Browse source
This commit is contained in:
Nikita Lisitsa 2022-01-12 19:18:24 +03:00
parent efc22a5bd7
commit 7babed1c57
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
libs/geom/include/psemek/geom/math.hpp
View file

@ -60,7 +60,7 @@ namespace psemek::geom
template <typename T> template <typename T>
T acos_over_sqrt_1_minus_x2(T const & x) T acos_over_sqrt_1_minus_x2(T const & x)
{ {
auto t = std::sqrt(T{1} - x * x); auto t = std::sqrt(std::max(T{0}, T{1} - x * x));
if (t < std::numeric_limits<T>::epsilon()) if (t < std::numeric_limits<T>::epsilon())
return T{1}; return T{1};
return std::acos(x) / t; return std::acos(x) / t;