lisyarus/psemek
1
0
Fork 1
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

Add name parameter to framebuffer::assert_complete for better error reporting

Browse source
This commit is contained in:
Nikita Lisitsa 2021-07-21 23:46:30 +03:00
parent 4eef4046cb
commit 1b6bc9a449
2 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
libs/gfx/include/psemek/gfx/framebuffer.hpp
View file

@ -6,6 +6,8 @@
#include <psemek/gfx/pixel.hpp> #include <psemek/gfx/pixel.hpp>
#include <psemek/gfx/pixmap.hpp> #include <psemek/gfx/pixmap.hpp>
#include <string_view>
namespace psemek::gfx namespace psemek::gfx
{ {
@ -50,7 +52,7 @@ namespace psemek::gfx
GLenum status() const; GLenum status() const;
bool complete() const; bool complete() const;
void assert_complete() const; void assert_complete(std::string_view name = {}) const;
template <typename Pixel> template <typename Pixel>
void read_pixels(basic_pixmap<Pixel> & p) const void read_pixels(basic_pixmap<Pixel> & p) const

6
libs/gfx/source/framebuffer.cpp
View file

@ -1,5 +1,7 @@
#include <psemek/gfx/framebuffer.hpp> #include <psemek/gfx/framebuffer.hpp>
#include <psemek/util/to_string.hpp>
namespace psemek::gfx namespace psemek::gfx
{ {
@ -178,10 +180,10 @@ namespace psemek::gfx
return status() == gl::FRAMEBUFFER_COMPLETE; return status() == gl::FRAMEBUFFER_COMPLETE;
} }
void framebuffer::assert_complete() const void framebuffer::assert_complete(std::string_view name) const
{ {
if (auto s = status(); s != gl::FRAMEBUFFER_COMPLETE) if (auto s = status(); s != gl::FRAMEBUFFER_COMPLETE)
throw std::runtime_error("Framebuffer incomplete: " + framebuffer_status_string(s)); throw std::runtime_error(util::to_string("Framebuffer ", name, name.empty() ? "" : " ", "incomplete: ", framebuffer_status_string(s)));
} }
framebuffer::framebuffer(std::nullptr_t) framebuffer::framebuffer(std::nullptr_t)